tvalentyn commented on code in PR #24599:
URL: https://github.com/apache/beam/pull/24599#discussion_r1132801046
##########
sdks/python/tox.ini:
##########
@@ -320,31 +320,30 @@ commands =
# Allow exit code 5 (no tests run) so that we can run this command safely on
arbitrary subdirectories.
/bin/sh -c 'pytest -o junit_suite_name={envname}
--junitxml=pytest_{envname}.xml -n 6 -m uses_pytorch {posargs}; ret=$?; [ $ret
= 5 ] && exit 0 || exit $ret'
-[testenv:py{37,38,39,310}-onnx-113]
+# TODO(https://github.com/apache/beam/issues/25796) - uncomment onnx tox task
once onnx supports protobuf 4.x.x
+# [testenv:py{37,38,39,310}-onnx-113]
# TODO(https://github.com/apache/beam/issues/25443)
# apparently tox has problem when substitution key has single value. Change
back to -onnx-{113,...}
# when multiple onnx versions are tested.
-deps =
- onnxruntime==1.13.1
- pandas==1.5.2
- torch==1.13.1
- tensorflow==2.11.0
- tf2onnx==1.13.0
- skl2onnx==1.13
- transformers==4.25.1
-extras = test,gcp
-commands =
- # Log onnx version for debugging
- /bin/sh -c "pip freeze | grep -E onnx"
- # Run all ONNX unit tests
- pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m
uses_onnx {posargs}
+# deps =
+# onnxruntime==1.13.1
+# pandas==1.5.2
+# torch==1.13.1
+# tensorflow==2.11.0
Review Comment:
In general, it is not common to have large chunks of commented out code in
the live codebase. It quickly rots and people tend to delete it when seeing it.
One option is to disable the task here:
https://github.com/apache/beam/blob/13a7cbf73f9db22fab5b7a8b5377bd8ec73538de/sdks/python/test-suites/tox/py38/build.gradle#L106,
which should probably be a 1-line change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
