Abacn commented on code in PR #25945:
URL: https://github.com/apache/beam/pull/25945#discussion_r1157571130
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -1026,7 +1027,7 @@ public void start() throws JMSException {
}
Review Comment:
Both is fine, if the flag is used then it should be consistent. For now if
closeProducer() is called, producer is closed and set to null, but this flag is
still true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
