Abacn commented on PR #25945: URL: https://github.com/apache/beam/pull/25945#issuecomment-1496440139
For the comment https://github.com/apache/beam/pull/25945#issuecomment-1496417672 > 1 - inside of the exception listener is there a potential racing condition to operate connection inside connection.exceptionListener? > 2 - inside of the loop This looks good at first glance. Though I still suggest to improvement one thing at a time, to get at lease a stable version first. Also, realized that close and connect need to be marked as synchronized -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
