Amraneze commented on PR #25945: URL: https://github.com/apache/beam/pull/25945#issuecomment-1497042746
> For the comment [#25945 (comment)](https://github.com/apache/beam/pull/25945#issuecomment-1496417672) > > > 1 - inside of the exception listener > > is there a potential racing condition to operate connection inside connection.exceptionListener? > > > 2 - inside of the loop > > This looks good at first glance. Though I still suggest to improvement one thing at a time, to get at lease a stable version first. > > Also, if we call close and connect inside `@ProcessElement` (other than `@setup` and `@teardown`), they need to be marked as synchronized methods I will try to see which solution have better performance. Should we add it with PoolConnection ? Just FYI, when there is an exception while publishing, the bundle is not republished because the message is sent to an output. That was the previous implementation and I wanted to keep backward compatibility. So if we remove that, we can just throw an exception and let Dataflow to retry the bundle without the retry policy. Here is a graph that explains the logic of JmsIO.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
