ryucc opened a new pull request, #26287:
URL: https://github.com/apache/beam/pull/26287
The current implementation tries to start the bundle, then adds an element
to the new bundle. countNewElement is a better naming, because
1. A new element is always added, but a bundle is not always started.
2. The only usage of this method is in DoFnOp.processElement, it reads
better to context.
We can also add a startBundle interface in the future, but there are
currently no use cases.
The new name changes the subject to adding an element as a theme, and
starting the bundle as a lazy side effect. It aligns more with what the method
is actually doing.
One symmetry we are breaking is in DoFnOp.processElement, we had a
`tryStartBundle` paired with a `tryFinishBundle`. Instead now we have
`countNewElement` paired with `tryFinishBundle`. I think the old reading favors
1 element per bundle, while the new reading favors multiple elements in a
bundle, and we check if the bundle is full/should be finished after each add.
Other changes:
1. Renamed some tests.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
