alnzng commented on PR #26287: URL: https://github.com/apache/beam/pull/26287#issuecomment-1511843167
+1 stick with the naming `tryStartBundle` because of the following: - Literally `BundleManager` is the place to manage the lifecycle of the bundle of events. It makes sense that it has a step/function to run `StartBundle` which maps to the DoFn's `StartBundle`[1]. - The current codes inside `tryStartBundle` does prepare for starting the bundle processing. For example, `bundleProgressListener.onBundleStarted()` actually invoke the underlying DoFn's `PushbackSideInputDoFnRunner.StartBundle` method. - Other Beam runners (e.g. Flink) does use a similar naming to callout `StartBundle` in their logical "BundleManager"[2]. -- Flink doesn't abstract its "BundleManger" into a separate class as how Samza does today, but the intention of related codes is similar. [1] https://beam.apache.org/releases/javadoc/2.2.0/org/apache/beam/sdk/transforms/ParDo.html [2] https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java#L674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
