ryucc commented on PR #26287: URL: https://github.com/apache/beam/pull/26287#issuecomment-1512852100
@mynameborat > The name tryStartBundle already reflects this although in retrospection, I don't see how `tryStartBundle` reflects adding an element to me. I would read `tryStartBundle` as if it hasn't started, start the bundle; else do nothing. Also having a bundle start with 1 element only makes half-sense to me. I like starting with 0, because when I count, I start counting from 0. It gives me security. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
