rshamunov commented on code in PR #26513:
URL: https://github.com/apache/beam/pull/26513#discussion_r1187228274
##########
playground/terraform/infrastructure/cloudbuild-manual-setup/02.builders/secret.tf:
##########
@@ -16,7 +20,7 @@ resource "google_secret_manager_secret"
"secret_gh_pat_cloudbuild" {
resource "google_secret_manager_secret_version"
"secret_webhook_cloudbuild_trigger_cicd_data" {
secret =
google_secret_manager_secret.secret_webhook_cloudbuild_trigger_cicd.id
- secret_data = var.data_for_cicd_webhook_secret
+ secret_data = random_string.data_for_cicd_webhook_secret.result
Review Comment:
This also should be pre-configured by user in GitHub WebHooks. Request the
parameter,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
