rshamunov commented on code in PR #26513: URL: https://github.com/apache/beam/pull/26513#discussion_r1187399826
########## playground/terraform/infrastructure/cloudbuild-manual-setup/README.md: ########## @@ -48,34 +48,25 @@ $BEAM_GIT/playground/terraform/environment/$ENVIRONMENT_NAME/common.tfvars ``` And put the following: ``` -playground_deploy_sa = "playground-deploy" -playground_update_sa = "playground-helm" -playground_ci_sa = "playground_ci" -playground_cd_sa = "playground_cd" -playground_environment_name = "playground-xxx" -playground_dns_name = "playground.dev" -playground_network_name = "playground-xxx" -playground_subnetwork_name = "playground-xxx" -playground_gke_name = "playground-xxx" -image_tag = "playground-xxx" -docker_repository_name = "playground-xxx" -playground_region = "europe-west3" -playground_zone = "europe-west3-c" +playground_deploy_sa = "DEPLOY_SA_NAME" +playground_update_sa = "UPDATE_SA_NAME" +playground_ci_sa = "CI_SA_NAME" +playground_cd_sa = "CD_SA_NAME" +project_id = "PROJECT_ID" +playground_environment_name = "ENVIRONMENT_NAME" +playground_dns_name = "DNS" +image_tag = "TAG" +playground_region = "REGION" +playground_zone = "ZONE" skip_appengine_deploy = false -ipaddress_name = "playground-xxx" -redis_name = "playground-xxx" -playground_service_account = "playground-xxx-sa" -datastore_namespace = "playground-xxx" -webhook_trigger_secret_id = "playground-xxx-wb" -gh_pat_secret = "playground-xxx" -data_for_github_pat_secret = "GH_SECRET" -data_for_cicd_webhook_secret = "RANDOM DATA" # will be automated -private_logs_bucket = "playground-xxx" +playground_service_account = "SA_NAME" +webhook_trigger_secret_id = "SECRET_ID" +gh_pat_secret = "PAT_SECRET_ID" +data_for_github_pat_secret = "PAT" trigger_source_repo = "https://github.com/apache/beam"; -project_id = "playground-xxx" terraform_source_repo = "https://github.com/apache/beam"; terraform_source_branch = "master" -state_bucket = "playground-xxx-terraform" +state_bucket = "BUCKET_NAME" Review Comment: Do we need variables for public and private logs buckets? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
