rshamunov commented on code in PR #26513: URL: https://github.com/apache/beam/pull/26513#discussion_r1187230238
########## playground/terraform/infrastructure/cloudbuild-manual-setup/README.md: ########## @@ -48,34 +48,25 @@ $BEAM_GIT/playground/terraform/environment/$ENVIRONMENT_NAME/common.tfvars ``` And put the following: ``` -playground_deploy_sa = "playground-deploy" -playground_update_sa = "playground-helm" -playground_ci_sa = "playground_ci" -playground_cd_sa = "playground_cd" -playground_environment_name = "playground-xxx" -playground_dns_name = "playground.dev" -playground_network_name = "playground-xxx" -playground_subnetwork_name = "playground-xxx" -playground_gke_name = "playground-xxx" -image_tag = "playground-xxx" -docker_repository_name = "playground-xxx" -playground_region = "europe-west3" -playground_zone = "europe-west3-c" +playground_deploy_sa = "DEPLOY_SA_NAME" +playground_update_sa = "UPDATE_SA_NAME" +playground_ci_sa = "CI_SA_NAME" +playground_cd_sa = "CD_SA_NAME" +project_id = "PROJECT_ID" +playground_environment_name = "ENVIRONMENT_NAME" Review Comment: Triggers not environment specific. Can you set environment-name to "environment" or "env" as default value for substitution and not request it? ########## playground/terraform/infrastructure/cloudbuild-manual-setup/README.md: ########## @@ -48,34 +48,25 @@ $BEAM_GIT/playground/terraform/environment/$ENVIRONMENT_NAME/common.tfvars ``` And put the following: ``` -playground_deploy_sa = "playground-deploy" -playground_update_sa = "playground-helm" -playground_ci_sa = "playground_ci" -playground_cd_sa = "playground_cd" -playground_environment_name = "playground-xxx" -playground_dns_name = "playground.dev" -playground_network_name = "playground-xxx" -playground_subnetwork_name = "playground-xxx" -playground_gke_name = "playground-xxx" -image_tag = "playground-xxx" -docker_repository_name = "playground-xxx" -playground_region = "europe-west3" -playground_zone = "europe-west3-c" +playground_deploy_sa = "DEPLOY_SA_NAME" +playground_update_sa = "UPDATE_SA_NAME" +playground_ci_sa = "CI_SA_NAME" +playground_cd_sa = "CD_SA_NAME" +project_id = "PROJECT_ID" +playground_environment_name = "ENVIRONMENT_NAME" +playground_dns_name = "DNS" Review Comment: DNS is not environment specific. Set to default value, e.g. "fqdn.your.playground.zone" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
