Abacn commented on code in PR #26923:
URL: https://github.com/apache/beam/pull/26923#discussion_r1214350326
##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -908,7 +908,7 @@ def test_in_global_window_with_text_file(self):
with tempfile.NamedTemporaryFile(suffix=".json") as f:
with open(f.name, "w") as fh:
json.dump(GroupIntoBatchesTest._create_test_data(), fh)
- with self.assertRaises(RuntimeError):
+ with self.assertRaises((RuntimeError, AttributeError)):
Review Comment:
I see, this means GroupIntoBatches still cannot working in direct runner. It
now throws AttributeError.
assertRaises here actually tests the feature gap for sdf_direct_runner exists
In this sense think unit test belongs to sdf_direct_runner_test:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/direct/sdf_direct_runner_test.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
