liferoad commented on code in PR #26923:
URL: https://github.com/apache/beam/pull/26923#discussion_r1214471226
##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -908,7 +908,7 @@ def test_in_global_window_with_text_file(self):
with tempfile.NamedTemporaryFile(suffix=".json") as f:
with open(f.name, "w") as fh:
json.dump(GroupIntoBatchesTest._create_test_data(), fh)
- with self.assertRaises(RuntimeError):
+ with self.assertRaises((RuntimeError, AttributeError)):
Review Comment:
Let me fix that test for windows. More tests are better. In particular, it
tests reading the actual file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
