Abacn commented on code in PR #26923:
URL: https://github.com/apache/beam/pull/26923#discussion_r1214446022
##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -908,7 +908,7 @@ def test_in_global_window_with_text_file(self):
with tempfile.NamedTemporaryFile(suffix=".json") as f:
with open(f.name, "w") as fh:
json.dump(GroupIntoBatchesTest._create_test_data(), fh)
- with self.assertRaises(RuntimeError):
+ with self.assertRaises((RuntimeError, AttributeError)):
Review Comment:
Fine. The test still fails on GitHub Action windows:
```
def test_in_global_window_with_text_file(self):
with tempfile.NamedTemporaryFile(suffix=".json") as f:
> with open(f.name, "w") as fh:
E PermissionError: [Errno 13] Permission denied:
'D:\\a\\beam\\beam\\sdks\\python\\target\\.tox\\py37-win\\tmp\\tmphcz3z87a.json'
```
a simpler test is suggested here:
https://github.com/apache/beam/issues/26836#issuecomment-1573128291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
