y1chi commented on code in PR #26085:
URL: https://github.com/apache/beam/pull/26085#discussion_r1237397174
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java:
##########
@@ -3067,8 +3069,14 @@ public void testExceptionInvalidatesCache() throws
Exception {
assertThat(
// The commit will include a timer to clean up state - this timer is
irrelevant
- // for the current test. Also remove source_bytes_processed because
it's dynamic.
-
setValuesTimestamps(commit.toBuilder().clearOutputTimers().clearSourceBytesProcessed())
+ // for the current test. Also remove source_bytes_processed and
+ // per_work_item_latecy_attributions because they're dynamic.
Review Comment:
Done.
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/FakeWindmillServer.java:
##########
@@ -367,6 +375,9 @@ public boolean commitWorkItem(
errorCollector.checkThat(
request.getShardingKey(), allOf(greaterThan(0L),
lessThan(Long.MAX_VALUE)));
errorCollector.checkThat(request.getCacheToken(), not(equalTo(0L)));
+ // Throw away per work item latency attributions because they are not
deterministic in tests
+ // for valid comparison.
+ request =
request.toBuilder().clearPerWorkItemLatencyAttributions().build();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
