y1chi commented on code in PR #26085:
URL: https://github.com/apache/beam/pull/26085#discussion_r1237401960
##########
runners/google-cloud-dataflow-java/worker/windmill/src/main/proto/windmill.proto:
##########
@@ -538,6 +574,10 @@ message StreamingGetWorkResponseChunk {
// from other stream_ids may be interleaved on the physical stream.
optional fixed64 stream_id = 4;
+ // Timing infos for the work item. Windmill Dispatcher and user worker should
+ // propagate critical event timings if the list is not empty.
+ repeated GetWorkStreamTimingInfo per_work_item_timing_infos = 8;
Review Comment:
I think we can do this as a follow up when we are seeing gaps from COMMITING
latency attribution and internal streamz commit latency metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
