y1chi commented on code in PR #26085:
URL: https://github.com/apache/beam/pull/26085#discussion_r1237397587
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/FakeWindmillServer.java:
##########
@@ -273,7 +277,11 @@ public boolean awaitTermination(int time, TimeUnit unit)
throws InterruptedExcep
computationWork.getInputDataWatermark());
for (Windmill.WorkItem workItem : computationWork.getWorkList()) {
receiver.receiveWork(
- computationWork.getComputationId(), inputDataWatermark,
Instant.now(), workItem);
+ computationWork.getComputationId(),
+ inputDataWatermark,
+ Instant.now(),
+ workItem,
+ new ArrayList<>());
Review Comment:
Done.
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/FakeWindmillServer.java:
##########
@@ -211,7 +211,11 @@ public CommitWorkResponse
commitWork(Windmill.CommitWorkRequest request) {
validateCommitWorkRequest(request);
for (ComputationCommitWorkRequest computationRequest :
request.getRequestsList()) {
for (WorkItemCommitRequest commit :
computationRequest.getRequestsList()) {
- commitsReceived.put(commit.getWorkToken(), commit);
+ // Throw away per work item latency attributions because they are not
deterministic in tests
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
