lostluck opened a new pull request, #27297:
URL: https://github.com/apache/beam/pull/27297
* Include jobs failed by requirements reasons pre-execution in the job list.
* More gracefully handle DoFn/SDK harness bundle failures instead of
panicking the runner.
* Adds context cancelation observation to the server side Control
implementation.
This adds an initial spot where Retries might be added in the future, and a
single point for where Job error messages will flow. Still todo is the right
way to surface the actual failure message to the user rather than in the runner
logs, since job failure states don't include messages. Likely would
pass/extract these along the message stream, which could also surface them on
the UI and API.
An SDK side change could be made to try and extract the last message from
the job management server if available, and produce that with the returned
error, but this would be SDK specific and per SDK without a more involved
JobManagement API change proposal.
This isn't a comprehensive overhaul of job abort, which likely needs more
work. I suspect that the full failure flow will need additional investigation,
such as when there are additional extant elements, and ensuring stray
goroutines are cleaned up.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
