jrmccluskey commented on code in PR #27297:
URL: https://github.com/apache/beam/pull/27297#discussion_r1253378980
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -233,19 +233,19 @@ func (wk *W) GetProcessBundleDescriptor(ctx
context.Context, req *fnpb.GetProces
//
// Requests come from the runner, and are sent to the client in the SDK.
func (wk *W) Control(ctrl fnpb.BeamFnControl_ControlServer) error {
- done := make(chan bool)
+ done := make(chan struct{})
Review Comment:
Question out of curiosity: why replace the boolean with an empty struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
