lostluck commented on code in PR #27297:
URL: https://github.com/apache/beam/pull/27297#discussion_r1253600840
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -233,19 +233,19 @@ func (wk *W) GetProcessBundleDescriptor(ctx
context.Context, req *fnpb.GetProces
//
// Requests come from the runner, and are sent to the client in the SDK.
func (wk *W) Control(ctrl fnpb.BeamFnControl_ControlServer) error {
- done := make(chan bool)
+ done := make(chan struct{})
Review Comment:
The empty struct is 0 size, and we don't have any semantics around what the
channel means. Technically, I should just be closing the channel at this point
instead of sending an empty struct but I suspect additional work is going to
happen in this area, so I won't change it again here. Currently, not closing
the channel doesn't affect whether it's garbage collected after the RPC returns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
