mkhludnev commented on code in PR #27333:
URL: https://github.com/apache/beam/pull/27333#discussion_r1254259210
##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/SchemaUtilTest.java:
##########
@@ -64,15 +64,17 @@ public void testToBeamSchema() throws SQLException {
JdbcFieldInfo.of("boolean_col", Types.BOOLEAN),
JdbcFieldInfo.of("char_col", Types.CHAR, 255),
JdbcFieldInfo.of("date_col", Types.DATE),
- JdbcFieldInfo.of("decimal_col", Types.DECIMAL),
+ JdbcFieldInfo.of("decimal_col", Types.DECIMAL, Integer.MAX_VALUE),
Review Comment:
but it means DECIMAL(0,0) zero precision, zero scale. Despite it's possible
in Java, it's not possible in real database, I believe. eg. If I attempt to
declare such column in Postgres I've got `NUMERIC precision 0 must be between 1
and 1000`. So, I fixed this stub to mimic real DB metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
