mkhludnev commented on code in PR #27333:
URL: https://github.com/apache/beam/pull/27333#discussion_r1254539375
##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/SchemaUtilTest.java:
##########
@@ -64,15 +64,17 @@ public void testToBeamSchema() throws SQLException {
JdbcFieldInfo.of("boolean_col", Types.BOOLEAN),
JdbcFieldInfo.of("char_col", Types.CHAR, 255),
JdbcFieldInfo.of("date_col", Types.DATE),
- JdbcFieldInfo.of("decimal_col", Types.DECIMAL),
+ JdbcFieldInfo.of("decimal_col", Types.DECIMAL, Integer.MAX_VALUE),
Review Comment:
@aromanenko-dev ... haaa after thinking a little, it turns not so obvious.
I'll roll back this line first, and then I'll play with integration tests a
little to prove or debunk my speculation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
