mkhludnev commented on code in PR #27333:
URL: https://github.com/apache/beam/pull/27333#discussion_r1254549861
##########
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/SchemaUtilTest.java:
##########
@@ -105,7 +109,9 @@ public void testToBeamSchema() throws SQLException {
.addField("boolean_col", Schema.FieldType.BOOLEAN)
.addField("char_col",
LogicalTypes.fixedLengthString(JDBCType.CHAR, 255))
.addField("date_col", LogicalTypes.JDBC_DATE_TYPE)
- .addField("decimal_col", Schema.FieldType.DECIMAL)
+ .addField("decimal_col", LogicalTypes.numeric(0, 0)) // doubtful
Review Comment:
even it's not degradation, it's really suspicious. Should we add
`precision==0` as magic condition into `SchemaUtil. beamLogicalNumericField
()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
