jrmccluskey commented on code in PR #28317:
URL: https://github.com/apache/beam/pull/28317#discussion_r1317616911
##########
sdks/go/pkg/beam/util/execx/exec.go:
##########
@@ -43,3 +44,20 @@ func ExecuteEnv(env map[string]string, prog string, args
...string) error {
return cmd.Run()
}
+
+// ExecuteEnvWithIO runs the program with the given arguments with additional
environment
+// variables. It attaches custom IO to the child process.
+func ExecuteEnvWithIO(env map[string]string, stdin io.Reader, stdout, stderr
io.Writer, prog string, args ...string) error {
+ cmd := exec.Command(prog, args...)
+ cmd.Stdin = stdin
Review Comment:
The type requirements are interfaces, so you cannot pass a nil value here.
You have to provide something that implements the respective io interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
