jrmccluskey commented on code in PR #28317:
URL: https://github.com/apache/beam/pull/28317#discussion_r1317617823
##########
sdks/python/container/boot.go:
##########
@@ -450,7 +450,7 @@ func processArtifactsInSetupOnlyMode() {
}
files[i] = filePayload.GetPath()
}
- if setupErr := installSetupPackages(files, workDir,
[]string{requirementsFile}); setupErr != nil {
+ if setupErr := installSetupPackages(context.Background(), nil, files,
workDir, []string{requirementsFile}); setupErr != nil {
Review Comment:
We have already had this discussion on the [design
doc](https://s.apache.org/beam-buffered-logging), that's where the logs were
being routed already before (despite not entirely making sense in that context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
