tvalentyn commented on code in PR #28317:
URL: https://github.com/apache/beam/pull/28317#discussion_r1317745223
##########
sdks/python/container/boot.go:
##########
@@ -450,7 +450,7 @@ func processArtifactsInSetupOnlyMode() {
}
files[i] = filePayload.GetPath()
}
- if setupErr := installSetupPackages(files, workDir,
[]string{requirementsFile}); setupErr != nil {
+ if setupErr := installSetupPackages(context.Background(), nil, files,
workDir, []string{requirementsFile}); setupErr != nil {
Review Comment:
> We can, although there's not a whole lot of extra pickup there because
everything will still be output at INFO in that case.
This is container prebuilding, so these logs would be reported elsewhere
(cloudbuild logs?), not Dataflow logs. Don't know what these look like.
I encourage you to test this manually by running container prebuilding
workflow with a custom SDK container image that has your changes.
Might not be a whole lot of value to obsess over these logs as long as they
are visible. If these helpers can be used in other contexts, i would suggest if
custom loggers are not specified, then stdout should go to stdout and stderr
should go to stderr. Sounds like you identified a place where we combine
everything and send both to stderr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
