lostluck opened a new pull request, #28545: URL: https://github.com/apache/beam/pull/28545
This PR allows prism to pass the 7 of the 8 tests in the Basic Xlang tests. This remains experimental for prism. Fixes a bug in Go SDK iterators where io.EOF was getting incorrectly wrapped, preventing downstream behavior on iterator read calls. Triggered by the Java CoGBK transform results. The CoGBK test is the only one that doesn't pass at present, but passing CoGBKResult output over cross language boundaries is uncommon. https://github.com/apache/beam/issues/28544 filed to resolve. * Allow startup and shutdown of multiple workers. * Worker stop is cleaned up to occur on post job context cancellation, so Serving has moved to each environment. * Open question: Maybe only start the worker for an environment if it executes something? GBK and Flatten are done runner side, and don't need their SDK environments... * Plumb through the "correct" worker for stages. * Allow prism to "support" Java CombineGlobally, and CombineByValues urns, by relying on the SDK backup implementation. * Similarly "support" the FireAlways trigger, by not failing pipelines that use it. However Prism doesn't yet actually support trigger behavior, but since only a single "ontime" fireing is implemented, current behavior is compatible with those triggers. * Stage enumeration is now based on the Topological sort/from fusion output. * Minor error/shutdown logging improvements. See #28187 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
