jrmccluskey commented on code in PR #28545:
URL: https://github.com/apache/beam/pull/28545#discussion_r1331743150
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -67,7 +67,7 @@ type W struct {
server *grpc.Server
// These are the ID sources
- inst, bund uint64
+ inst uint64
Review Comment:
This is now being pulled from the ProcessBundle instruction abstraction
directly, right?
##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -95,7 +92,7 @@ func makeWorker(env string, j *jobservices.Job) (*worker.W,
error) {
// Check for connection succeeding after we've created the environment
successfully.
timeout := 1 * time.Minute
time.AfterFunc(timeout, func() {
- if wk.Connected() {
+ if wk.Connected() || wk.Stopped() {
Review Comment:
Is there a case where Stopped() could be indicative of an error in worker
start-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
