lostluck commented on code in PR #28545:
URL: https://github.com/apache/beam/pull/28545#discussion_r1331794537
##########
sdks/go/pkg/beam/runners/prism/internal/worker/worker.go:
##########
@@ -67,7 +67,7 @@ type W struct {
server *grpc.Server
// These are the ID sources
- inst, bund uint64
+ inst uint64
Review Comment:
Just the bundle descriptor IDs.
The shorter lived RPCs like Progress and Split still use the Instruction IDs
from the worker side, rather than the "global" one in execute used by the
ElementManager.
I haven't yet nailed down the best way to have "global" state accessed by
the worker abstraction, vs dedicated state (like environment protos). It's
getting there though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
