Abacn commented on code in PR #28590:
URL: https://github.com/apache/beam/pull/28590#discussion_r1337550437
##########
sdks/java/io/hadoop-common/src/main/java/org/apache/beam/sdk/io/hadoop/SerializableConfiguration.java:
##########
@@ -54,8 +58,15 @@ public Configuration get() {
@Override
public void writeExternal(ObjectOutput out) throws IOException {
+ if (serializationCache == null) {
Review Comment:
Sorry I may missed something. `readExternal` is used to deserialize
ObjectInput into conf that handled by SerializableConfiguration.
SerializableConfiguration itself may or may not have empty cache. If there is a
writeExternal called prior to readExternal (regardless of caller, this
technically could be the case) then the cache was not empty and should be
invalidated.
Also, should we make serializationCache synchronized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
