Abacn commented on code in PR #28590:
URL: https://github.com/apache/beam/pull/28590#discussion_r1337654125
##########
sdks/java/io/hadoop-common/src/main/java/org/apache/beam/sdk/io/hadoop/SerializableConfiguration.java:
##########
@@ -54,8 +58,15 @@ public Configuration get() {
@Override
public void writeExternal(ObjectOutput out) throws IOException {
+ if (serializationCache == null) {
Review Comment:
> because the implementation of SerializableConfiguration isn't thread-safe.
Thanks for explanation, then current implementation looks sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
