ddebowczyk92 commented on code in PR #28590:
URL: https://github.com/apache/beam/pull/28590#discussion_r1337635453
##########
sdks/java/io/hadoop-common/src/main/java/org/apache/beam/sdk/io/hadoop/SerializableConfiguration.java:
##########
@@ -54,8 +58,15 @@ public Configuration get() {
@Override
public void writeExternal(ObjectOutput out) throws IOException {
+ if (serializationCache == null) {
Review Comment:
okay you are right, technically it's possible. I added cache invalidation in
a PR update.
to be honest, I didn't consider making serializationCache synchronized,
because the implementation of SerializableConfiguration isn't thread-safe.
Anytime a value is assigned to serializationCache variable or set to null
surrounded it could be surrounded by synchronization block. Or maybe you have
other idea on your mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
