robertwb commented on code in PR #27851:
URL: https://github.com/apache/beam/pull/27851#discussion_r1349372390
##########
sdks/java/core/build.gradle:
##########
@@ -124,5 +121,5 @@ dependencies {
}
project.tasks.compileTestJava {
- options.compilerArgs += ['-Xlint:-rawtypes'] // generated avro uses rawtypes
without suppression
+ options.compilerArgs += ['-Xlint:-rawtypes']
Review Comment:
Can this still not be removed?
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/CountingSource.java:
##########
@@ -485,8 +486,8 @@ public long getSplitBacklogBytes() {
* The checkpoint for an unbounded {@link CountingSource} is simply the last
value produced. The
* associated source object encapsulates the information needed to produce
the next value.
*/
- @DefaultCoder(AvroCoder.class)
- public static class CounterMark implements UnboundedSource.CheckpointMark {
+ @DefaultCoder(SerializableCoder.class)
Review Comment:
We should make a note about this (as well as the larger change) in
CHANGES.md.
Serialization isn't guaranteed to be stable either--if we're switching
coders should we switch to a custom (or Beam-schema-based) coder here?
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/CountingSource.java:
##########
@@ -485,8 +486,8 @@ public long getSplitBacklogBytes() {
* The checkpoint for an unbounded {@link CountingSource} is simply the last
value produced. The
* associated source object encapsulates the information needed to produce
the next value.
*/
- @DefaultCoder(AvroCoder.class)
- public static class CounterMark implements UnboundedSource.CheckpointMark {
+ @DefaultCoder(SerializableCoder.class)
Review Comment:
It worries me a bit that there is no workaround. I suppose we could advise
copying the old CountingSource into your own project and using that directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
