aromanenko-dev commented on code in PR #27851:
URL: https://github.com/apache/beam/pull/27851#discussion_r1352794181
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/CountingSource.java:
##########
@@ -485,8 +486,8 @@ public long getSplitBacklogBytes() {
* The checkpoint for an unbounded {@link CountingSource} is simply the last
value produced. The
* associated source object encapsulates the information needed to produce
the next value.
*/
- @DefaultCoder(AvroCoder.class)
- public static class CounterMark implements UnboundedSource.CheckpointMark {
+ @DefaultCoder(SerializableCoder.class)
Review Comment:
> Serialization isn't guaranteed to be stable either--if we're switching
coders should we switch to a custom (or Beam-schema-based) coder here?
Yes, we can switch to custom coder, but what will be the advantage over
`SerializableCoder` in this case? I'm not sure that I understand right this
"Serialization isn't guaranteed to be stable either".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
