robertwb commented on code in PR #27851: URL: https://github.com/apache/beam/pull/27851#discussion_r1355337618
########## CHANGES.md: ########## @@ -57,8 +57,8 @@ ## Highlights -* New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)). -* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)). +* Previously deprecated Avro-dependent code has been finally removed from Java SDK "core" package. Please, use Review Comment: If you want, you could add another sentence about the benefits of this change. ########## sdks/java/core/src/main/java/org/apache/beam/sdk/io/CountingSource.java: ########## @@ -354,7 +356,7 @@ public UnboundedReader<Long> createReader(PipelineOptions options, CounterMark c @Override public Coder<CountingSource.CounterMark> getCheckpointMarkCoder() { - return AvroCoder.of(CountingSource.CounterMark.class); + return SerializableCoder.of(CountingSource.CounterMark.class); Review Comment: I think this needs to change too. (And no need to add the Serializable interface anymore.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
