tysonjh commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r468749356
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
state.add(1)
yield element
- if self.get_option_or_default('streaming', False):
+ if self.get_option_or_default(
+ 'streaming',
+ False) and self.pipeline.get_option('runner') == "PortableRunner":
Review comment:
Right, I remember you mentioned there was some issue with the
SyntheticSource that Max ran into. Ideally Synthetic source would work for all
standard uses but I'm not familiar with the details. How big of a change would
it be to fix SyntheticSource?
I'm OK with moving forward with this change, creating a Jira issue for
tracking the SyntheticSource improvement, and noting it here as a TODO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
