tysonjh commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r474839396
##########
File path: .test-infra/jenkins/job_LoadTests_ParDo_Python.groovy
##########
@@ -151,3 +151,35 @@
CronJobBuilder.cronJob('beam_LoadTests_Python_ParDo_Dataflow_Batch', 'H 13 * * *
]
batchLoadTestJob(delegate,
CommonTestProperties.TriggeringContext.POST_COMMIT)
}
+
+def streamingLoadTestJob = { scope, triggeringContext ->
+ scope.description('Runs Python ParDo load tests on Dataflow runner in
streaming mode')
+ commonJobProperties.setTopLevelMainJobProperties(scope, 'master', 120)
+
+ def datasetName = loadTestsBuilder.getBigQueryDataset('load_test',
triggeringContext)
+ for (testConfiguration in loadTestConfigurations("streaming", datasetName)) {
+ // Skipping case 2 in streaming because it timeouts. To be checked TODO:
kkucharc
+ if(testConfiguration.title != "ParDo Python Load test: 2GB 100 byte
records 200 times") {
Review comment:
Hm, good point. I just reviewed @kamilwu PR#12612 and was a bit uneasy
that it used indices for ignoring tests but didn't make a comment. Maybe it is
worth updating that PR follow this approach instead for the reasons you mention
and uniformity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
