tvalentyn commented on code in PR #28614:
URL: https://github.com/apache/beam/pull/28614#discussion_r1373523839
##########
runners/flink/flink_runner.gradle:
##########
@@ -314,12 +316,20 @@ def createValidatesRunnerTask(Map m) {
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testFirstElementLate'
// https://github.com/apache/beam/issues/20844
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testLateDataAccumulating'
+ if (!config.streaming) {
+ // FlinkBatchExecutionInternalTimeService does not support timer
registration on timer firing.
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimestampTests.testOnTimerTimestampSkew'
+ } else {
+ // https://github.com/apache/beam/issues/25485
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState'
Review Comment:
is this still necessary (test still flaky)? Does this PR make the test more
flaky?
##########
CHANGES.md:
##########
@@ -339,6 +339,9 @@ as a workaround, a copy of "old" `CountingSource` class
should be placed into a
* The Go SDK now requires Go 1.19 to build.
([#25545](https://github.com/apache/beam/pull/25545))
* The Go SDK now has an initial native Go implementation of a portable Beam
Runner called Prism. ([#24789](https://github.com/apache/beam/pull/24789))
* For more details and current state see
https://github.com/apache/beam/tree/master/sdks/go/pkg/beam/runners/prism.
+* Add `UseDataStreamForBatch` pipeline option to the Flink runner. When it is
set to true, Flink runner will run batch
Review Comment:
Please update this file; this change needs to move up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
