jto commented on code in PR #28614:
URL: https://github.com/apache/beam/pull/28614#discussion_r1374614425
##########
runners/flink/flink_runner.gradle:
##########
@@ -314,12 +316,20 @@ def createValidatesRunnerTask(Map m) {
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testFirstElementLate'
// https://github.com/apache/beam/issues/20844
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testLateDataAccumulating'
+ if (!config.streaming) {
+ // FlinkBatchExecutionInternalTimeService does not support timer
registration on timer firing.
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimestampTests.testOnTimerTimestampSkew'
+ } else {
+ // https://github.com/apache/beam/issues/25485
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState'
Review Comment:
I tried all the tests in
`org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests` and
`org.apache.beam.sdk.transforms.ParDoTest$TimestampTests` 10 times for each
validation (`validatesRunnerBatch`, `validatesRunnerBatchWithDataStream` and
`validatesRunnerStreaming`) .
`testOnTimerTimestampSkew` never passes with
`validatesRunnerBatchWithDataStream` which I think explains why this test is
disabled. `GroupByKeyTest$BasicTests` on the other end always passes so I think
this one does not need to be excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
