jto commented on code in PR #28614:
URL: https://github.com/apache/beam/pull/28614#discussion_r1374813892


##########
runners/flink/flink_runner.gradle:
##########
@@ -314,12 +316,20 @@ def createValidatesRunnerTask(Map m) {
         excludeTestsMatching 
'org.apache.beam.sdk.testing.TestStreamTest.testFirstElementLate'
         // https://github.com/apache/beam/issues/20844
         excludeTestsMatching 
'org.apache.beam.sdk.testing.TestStreamTest.testLateDataAccumulating'
+        if (!config.streaming) {
+          // FlinkBatchExecutionInternalTimeService does not support timer 
registration on timer firing.
+          excludeTestsMatching 
'org.apache.beam.sdk.transforms.ParDoTest$TimestampTests.testOnTimerTimestampSkew'
+        } else {
+          // https://github.com/apache/beam/issues/25485
+          excludeTestsMatching 
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState'

Review Comment:
   I think the reason `testOnTimerTimestampSkew` fails when using the 
datastream API for batch is 
[FLINK-18647](https://issues.apache.org/jira/browse/FLINK-18647). I don't know 
how to fix it though. Let me know if you have ideas.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to