Polber commented on code in PR #29261:
URL: https://github.com/apache/beam/pull/29261#discussion_r1379609838
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformProvider.java:
##########
@@ -78,7 +77,7 @@ public class KafkaReadSchemaTransformProvider
public static final TupleTag<Row> OUTPUT_TAG = new TupleTag<Row>() {};
public static final TupleTag<Row> ERROR_TAG = new TupleTag<Row>() {};
public static final Schema ERROR_SCHEMA =
-
Schema.builder().addStringField("error").addNullableByteArrayField("row").build();
+ Schema.builder().addNullableByteArrayField("row").build();
Review Comment:
@robertwb Since the input to the ValueMapping DoFn is a `byte[]`, I have to
wrap it in a row with an arbitrary field, in this case "row". WDYT about this
naming?
i.e. `Row(failed_row=Row(row="bad payload"), error_message="Exception...")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
