Polber commented on code in PR #29261:
URL: https://github.com/apache/beam/pull/29261#discussion_r1380488541
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformProvider.java:
##########
@@ -138,59 +158,23 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
PCollection<byte[]> kafkaValues =
input.getPipeline().apply(kafkaRead.withoutMetadata()).apply(Values.create());
+ Schema errorSchema = ErrorHandling.errorSchema(ERROR_SCHEMA);
Review Comment:
Ok, I did that initially, but I wan't sure if that would mess with our
Row-based approach. I can refactor that and test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
