robertwb commented on code in PR #29261:
URL: https://github.com/apache/beam/pull/29261#discussion_r1380483200
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformProvider.java:
##########
@@ -138,59 +158,23 @@ public PCollectionRowTuple expand(PCollectionRowTuple
input) {
PCollection<byte[]> kafkaValues =
input.getPipeline().apply(kafkaRead.withoutMetadata()).apply(Values.create());
+ Schema errorSchema = ErrorHandling.errorSchema(ERROR_SCHEMA);
Review Comment:
This probably shouldn't be an ErrorSchema of ERROR_SCHEMA.
We should add a errorSchema(FieldType) overload, where bytes is the thing to
pass here. I know John Casey is looking at DLQ stuff where we might want to
refactor this a bit more. (I suppose we're calling YAML stable, but the
formatting of the error messages may have to change.)
##########
sdks/python/apache_beam/yaml/yaml_transform.py:
##########
@@ -227,6 +227,8 @@ def get_pcollection(self, name):
outputs = self.get_outputs(transform)
if output in outputs:
return outputs[output]
+ elif len(outputs) == 1 and outputs[next(iter(outputs))].tag == output:
Review Comment:
Ah, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
