tomstepp commented on code in PR #29395:
URL: https://github.com/apache/beam/pull/29395#discussion_r1391772243


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java:
##########
@@ -59,6 +60,10 @@ public String getUrn() {
     @Override
     public RunnerApi.FunctionSpec translate(
         AppliedPTransform<?, ?, Unbounded<?>> transform, SdkComponents 
components) {
+      if (ExperimentalOptions.hasExperiment(

Review Comment:
   Oh I actually looked at the code and seems that replaceV1Transforms may be 
intended to run for both versions. In that case I'm not sure yet if it actually 
runs or if the replacement fails on v2 for another reason.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to