tomstepp commented on code in PR #29395:
URL: https://github.com/apache/beam/pull/29395#discussion_r1391776862


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java:
##########
@@ -59,6 +60,10 @@ public String getUrn() {
     @Override
     public RunnerApi.FunctionSpec translate(
         AppliedPTransform<?, ?, Unbounded<?>> transform, SdkComponents 
components) {
+      if (ExperimentalOptions.hasExperiment(

Review Comment:
   Looks like replaceV1Transforms is only used for v1. The portable job 
submission proto is created ahead of this at line 1170 for v2 jobs. Is it a 
suitable+better fix to run replaceV1Transforms before creating 
portablePipelineProto?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to