Abacn commented on code in PR #29395:
URL: https://github.com/apache/beam/pull/29395#discussion_r1393078349
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/ExperimentalOptions.java:
##########
@@ -35,6 +35,10 @@ public interface ExperimentalOptions extends PipelineOptions
{
String STATE_SAMPLING_PERIOD_MILLIS = "state_sampling_period_millis";
+ String ENABLE_CUSTOM_PUBSUB_SOURCE = "enable_custom_pubsub_source";
Review Comment:
Thanks, however, I meant because now we used this experiment in both places,
it is better to define the constant in PubsubIO. google-cloud-dataflow-java
depends on sdks-io-google-cloud-platform so it is fine refer to PubsubIO's
constant inside DataflowRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
