tomstepp commented on code in PR #29395:
URL: https://github.com/apache/beam/pull/29395#discussion_r1393372057


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubSubPayloadTranslation.java:
##########
@@ -59,6 +60,10 @@ public String getUrn() {
     @Override
     public RunnerApi.FunctionSpec translate(
         AppliedPTransform<?, ?, Unbounded<?>> transform, SdkComponents 
components) {
+      if (ExperimentalOptions.hasExperiment(

Review Comment:
   I don't think the check is needed since it's replacing the _unbounded_ 
version, which should already only be used for streaming jobs. But please lmk 
if there's any concerns with this, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to