Abacn commented on code in PR #29478:
URL: https://github.com/apache/beam/pull/29478#discussion_r1405586350
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileSystemsTest.java:
##########
@@ -316,6 +317,24 @@ public void testInvalidSchemaMatchNewResource() {
assertEquals("file", FileSystems.matchNewResource("c:/tmp/f1", false));
}
+ @Test
Review Comment:
error on windows:
```
org.junit.ComparisonFailure: expected:<[/abc/d/]> but was:<[E:\abc\d\]>
at org.junit.Assert.assertEquals(Assert.java:117)
```
Fixed by comparing resourceId and not converting to String, which will give
OS specific valid paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
