Abacn commented on code in PR #29478:
URL: https://github.com/apache/beam/pull/29478#discussion_r1423100970
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/TestDataflowRunner.java:
##########
@@ -74,8 +74,13 @@ public class TestDataflowRunner extends
PipelineRunner<DataflowPipelineJob> {
public static TestDataflowRunner fromOptions(PipelineOptions options) {
TestDataflowPipelineOptions dataflowOptions =
options.as(TestDataflowPipelineOptions.class);
String tempLocation =
- Joiner.on("/")
- .join(dataflowOptions.getTempRoot(), dataflowOptions.getJobName(),
"output", "results");
+ FileSystems.matchNewDirectory(
+ dataflowOptions.getTempRoot(), dataflowOptions.getJobName(),
"output", "results")
+ .toString();
+ // to keep exact same behavior prior to matchNewDirectory introduced
+ if (tempLocation.endsWith("/") || tempLocation.endsWith("\\")) {
Review Comment:
change applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
