Abacn commented on code in PR #29478:
URL: https://github.com/apache/beam/pull/29478#discussion_r1423083484
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileSystemsTest.java:
##########
@@ -316,6 +317,25 @@ public void testInvalidSchemaMatchNewResource() {
assertEquals("file", FileSystems.matchNewResource("c:/tmp/f1", false));
}
+ @Test
+ public void testMatchNewDirectory() {
Review Comment:
this test works for all platforms (we have GHA for it). The initial commit
was failing on windows but then fixed in followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
