bsannicolas commented on code in PR #29849:
URL: https://github.com/apache/beam/pull/29849#discussion_r1439657579
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -529,7 +541,7 @@ def typing_from_runner_api(
return Any
else:
return LogicalType.from_runner_api(
- fieldtype_proto.logical_type).language_type()
+ fieldtype_proto.logical_type)._language_type()
Review Comment:
I don't think it's strictly necessary, but `language_type` is a class method
and called that way in some places. For a type with arguments, where the
arguments determine the type, it doesn't make sense to call `language_type`
statically, as the argument will be missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
